Add wheel scroll settings by klovinad · Pull Request #94 · AprilNEA/OpenLogi

klovinad · 2026-06-02T21:11:30Z

Summary

This proposes two related mouse-control improvements:

Change the default horizontal gesture-button swipes to switch macOS desktops/spaces:
- Left → Previous Desktop
- Right → Next Desktop
Add app-wide scroll wheel preferences:
- invert wheel direction
- scroll strength multiplier
- tactility/chunking

Implementation notes

Scroll preferences are persisted in AppSettings and mirrored into the hook runtime through a shared ScrollSettings value.
The hook transforms captured scroll events only when non-default scroll settings are active; default settings pass through natively.
Synthetic transformed scroll events are posted at the session tap to avoid being re-captured by OpenLogi's own HID event tap.
Added unit coverage for scroll axis ordering, inversion, and chunking.

Verification

Ran locally on macOS:

cargo fmt --all
cargo check -p openlogi-gui
cargo test -p openlogi-gui -p openlogi-core

Results:

openlogi-core: 34 passed
openlogi-gui: 14 passed

pullfrog

ℹ️ Minor suggestions inline — one observation about the scroll-settings default check.

Reviewed changes — Adds three scroll-preference controls (invert, strength, tactility) to the Settings window and changes default horizontal gesture swipes to desktop/Space switching.

Default gesture direction update — PrevTab/NextTab replaced with PreviousDesktop/NextDesktop.
ScrollSettings shared state — Arc<RwLock<ScrollSettings>> mirrors the persisted config to the hook runtime.
Scroll event transformation — transform_scroll/quantize_scroll apply inversion, strength, and chunking to captured wheel events.
Session-tap re-injection — Transformed scroll events are posted at CGEventTapLocation::Session to avoid re-capture by OpenLogi's HID tap.
Settings UI — Invert switch, strength slider (1–10), and tactility slider (0–10) in a new "Scroll" group box.
Generalized setting_row — Signature changed from control: Switch to control: impl IntoElement to accept sliders alongside switches.
Expanded native-click passthrough — Back→BrowserBack and Forward→BrowserForward added.

^{｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using Big Pickle (free) (credentials for Anthropic not configured) ｜ 𝕏}

pullfrog

✅ Prior feedback addressed — no new issues found.

Reviewed changes — Fixed the ScrollSettings::default() mismatch with AppSettings defaults by replacing the derived Default with a manual impl whose strength: 1 matches the app config.

Manual Default impl for ScrollSettings — Replaced #[derive(Default)] with a manual impl Default where strength: 1 aligns with AppSettings::wheel_strength. This restores the identity fast-path in hook_runtime.rs.

^{｜ View workflow run ｜ Using Big Pickle (free) (credentials for Anthropic not configured) ｜ 𝕏}

averypelle · 2026-06-04T15:16:06Z

This should close #126

phuocleoceo · 2026-06-09T03:35:33Z

I'm really interested in the "invert wheel direction" feature. Thanks for bringing it up in this Pull Request, I hope it gets merged into the software soon!

shawnflanagan · 2026-06-09T18:58:19Z

Let's get these conflicts resolved so we can merge this. Invert wheel direction is sorely needed in the app

averypelle · 2026-06-10T19:53:32Z

for anyone looking for an interim fix, https://pilotmoon.com/scrollreverser/ is compatible with this app

greptile-apps · 2026-06-14T09:14:33Z

Greptile Summary

This PR adds app-wide scroll wheel preferences (invert direction, strength multiplier, tactility/chunking) persisted in AppSettings and mirrored into the hook runtime via a shared ScrollSettings value. On macOS the original CGEvent is mutated in-place inside the HID tap callback; on other platforms the original event is suppressed and a synthetic event is re-injected.

ScrollSettings / SharedScrollSettings are threaded from the orchestrator through hook_runtime::start into the tap callback, with a short-circuit for default settings and trackpad events.
Action::execute is consolidated into openlogi-core/src/binding.rs with platform-specific helpers for macOS (CGEventPost), Linux (uinput), and Windows (SendInput).
Settings UI adds an invert toggle and two sliders (strength 1–10, tactility 0–10) wired to AppState setters that persist and reload config.

Confidence Score: 4/5

Safe to merge after fixing the synthetic-scroll re-processing issue in post_scroll on macOS.

The new post_scroll function in binding.rs posts scroll events at CGEventTapLocation::HID without tagging them with SYNTHETIC_EVENT_USER_DATA. post_click and post_other_button both call tag_synthetic to prevent re-entry, and the translate function already lists ScrollWheel as a candidate for the synthetic check — but an untagged post_scroll event carries user-data 0, so the guard never fires. When scroll settings are non-default and a button is bound to a scroll action, pressing it posts an untagged scroll event that the hook picks up, applies the scroll transform to, and re-emits with inverted or amplified deltas. The rest of the change — the in-place CGEvent mutation path, the Linux/Windows injection paths, config serialization, and the UI — is straightforward and correct.

crates/openlogi-core/src/binding.rs — macos::post_scroll needs tag_synthetic(&ev) before ev.post(CGEventTapLocation::HID)

Important Files Changed

Filename	Overview
crates/openlogi-core/src/binding.rs	Adds `Action::execute` with platform-specific implementations (macOS, Linux, Windows). On macOS, `post_scroll` is introduced without tagging the synthetic event, causing button-bound scroll actions to be re-processed by OpenLogi's own HID tap when non-default scroll settings are active.
crates/openlogi-hook/src/macos.rs	Adds `transform_scroll_event` for in-place CGEvent scroll mutation (inverted, strength, tactility). The `TransformScroll` disposition wires correctly into `thread_main`. Logic is sound and avoids the re-injection loop because the original event is mutated at the HID tap rather than re-posted.
crates/openlogi-agent-core/src/hook_runtime.rs	Adds `ScrollSettings` struct and `SharedScrollSettings`, wires scroll settings into the hook callback, with short-circuit for default settings and trackpad events. Non-macOS zero-delta path correctly returns `PassThrough`.
crates/openlogi-core/src/config.rs	Adds `wheel_inverted`, `wheel_strength`, `wheel_tactility` fields to `AppSettings` with serde defaults; default strength returns 1 via const fn.
crates/openlogi-gui/src/windows/settings.rs	Adds wheel invert toggle, strength slider, and tactility slider to the general settings page. UI-level range constraints (1–10 for strength, 0–10 for tactility) match `AppState` clamping.
crates/openlogi-gui/src/state.rs	Adds `set_wheel_inverted`, `set_wheel_strength` (clamped 1–10), `set_wheel_tactility` (clamped 0–10) setters that persist and reload config.
crates/openlogi-hook/src/lib.rs	Adds `TransformScroll(ScrollTransform)` variant to `EventDisposition` and defines the `ScrollTransform` struct. Linux hook treats it as `PassThrough` as documented.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant HW as Hardware Wheel
    participant Tap as CGEventTap (HID)
    participant Hook as hook_runtime cb
    participant OS as macOS Event Pipeline

    HW->>Tap: CGEventType::ScrollWheel
    Tap->>Hook: "MouseEvent::Scroll { delta_x, delta_y, from_trackpad }"
    alt "settings == default OR from_trackpad"
        Hook-->>Tap: PassThrough
        Tap->>OS: original event unchanged
    else non-default settings, not trackpad
        Hook-->>Tap: "TransformScroll { inverted, strength, tactility }"
        Tap->>Tap: transform_scroll_event() — mutate CGEvent in-place
        Tap->>OS: modified event (no re-entry)
    end

    Note over Tap,OS: Button-bound Action::ScrollUp path
    participant Btn as Button Action
    Btn->>OS: post_scroll() at CGEventTapLocation::HID (untagged)
    OS->>Tap: CGEventType::ScrollWheel (no SYNTHETIC_EVENT_USER_DATA)
    Tap->>Hook: MouseEvent::Scroll (re-enters hook)
    alt "settings != default"
        Hook-->>Tap: TransformScroll (applied again — wrong direction/magnitude)
    end

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant HW as Hardware Wheel
    participant Tap as CGEventTap (HID)
    participant Hook as hook_runtime cb
    participant OS as macOS Event Pipeline

    HW->>Tap: CGEventType::ScrollWheel
    Tap->>Hook: "MouseEvent::Scroll { delta_x, delta_y, from_trackpad }"
    alt "settings == default OR from_trackpad"
        Hook-->>Tap: PassThrough
        Tap->>OS: original event unchanged
    else non-default settings, not trackpad
        Hook-->>Tap: "TransformScroll { inverted, strength, tactility }"
        Tap->>Tap: transform_scroll_event() — mutate CGEvent in-place
        Tap->>OS: modified event (no re-entry)
    end

    Note over Tap,OS: Button-bound Action::ScrollUp path
    participant Btn as Button Action
    Btn->>OS: post_scroll() at CGEventTapLocation::HID (untagged)
    OS->>Tap: CGEventType::ScrollWheel (no SYNTHETIC_EVENT_USER_DATA)
    Tap->>Hook: MouseEvent::Scroll (re-enters hook)
    alt "settings != default"
        Hook-->>Tap: TransformScroll (applied again — wrong direction/magnitude)
    end

_{Reviews (10): Last reviewed commit: "Merge master into proposal/wheel-scroll-..." | Re-trigger Greptile}

AprilNEA

Thanks for this — invert-scroll is clearly in demand (#126 plus the comments here). Before merging I want to flag some concerns with the current approach, because the suppress-and-reinject design has a few real problems on macOS, and one of them is that it doesn't actually solve #126 as written.

1. It doesn't solve #126 (per-device inversion)

#126 specifically asks to keep the trackpad on natural scrolling and invert only the mouse. The hook taps at CGEventTapLocation::HID (crates/openlogi-hook/src/macos.rs:257) and captures every ScrollWheel event regardless of source, and transform_scroll never looks at kCGScrollWheelEventIsContinuous. So enabling invert flips the trackpad too — exactly the native-setting behavior #126 wants to avoid. We shouldn't close #126 with this as-is.

2. Modifier flags are dropped

post_scroll_delta builds a fresh CGEvent::new_scroll_event(...) and never copies the original event's flags. Modifier+scroll gestures that apps read off the event flags (zoom, etc.) will stop working while non-default settings are active. (System-level Ctrl+scroll screen zoom reads live key state and may be unaffected — worth verifying on-device.)

3. Momentum / pixel precision are lost

We suppress the original and re-emit ScrollEventUnit::LINE from the rounded AXIS_1/AXIS_2 line deltas. That drops scroll-phase/momentum and ignores the pixel POINT_DELTA_* fields, so continuous input (trackpad, MX free-spin high-res wheel) becomes coarse. Micro-deltas round to 0 → PassThrough, so on a free-spinning wheel small movements aren't inverted while fast ones are — inconsistent. Given our primary devices are MX-class, this matters.

4. Per-event cost on the hottest path

The macOS tap must stay lock-light or it stalls the whole input stream (see the comments in macos.rs). This adds an RwLock read per scroll event and, when active, a fresh CGEventSource::new + CGEvent allocation per event. On a high-rate free-spin stream that risks TapDisabledByTimeout / scroll stutter.

Suggested approach

Instead of suppress + reinject, mutate the event in place and return Keep. We already do in-place field writes elsewhere (crates/openlogi-core/src/binding.rs:1312,1327), and the same set_*_value_field works on the callback's &CGEvent. Negate/scale AXIS_1/AXIS_2 plus the POINT_DELTA_* and fixed-point fields and keep the event — that preserves momentum, pixel precision, flags, and continuity, with zero allocation and no re-entry concern. For #126, branch on kCGScrollWheelEventIsContinuous to apply inversion to discrete (mouse) scroll only. This is essentially how Scroll Reverser does it.

Unrelated change

The default gesture remap (PrevTab/NextTab → PreviousDesktop/NextDesktop) is a separate UX decision — please split it into its own PR so each can be reviewed/reverted independently.

The config plumbing, clamping, and default fast-path are clean; the concern is purely the macOS transform path. Happy to help iterate on the in-place version.

zekunyan · 2026-06-19T17:35:04Z

Looking forward to this feature! :)

AprilNEA · 2026-06-22T14:12:35Z

Thanks again for putting this together — it helped clarify the scroll settings direction.

The per-device inverted scrolling part has now landed separately in #294 and is available in v0.6.16, so this PR is mostly superseded for that use case. Since the remaining pieces here (scroll strength multiplier, tactility/chunking, and default gesture-swipe changes) are distinct behavior changes, I'm going to close this PR rather than keep a broad overlapping branch open.

If you still want to pursue any of the remaining pieces, a smaller PR focused on just one behavior would be very welcome. Thanks for the contribution!

klovinad · 2026-06-22T16:09:08Z

gg

pullfrog Bot reviewed Jun 2, 2026

View reviewed changes

Comment thread crates/openlogi-gui/src/hook_runtime.rs Outdated

pullfrog Bot reviewed Jun 2, 2026

View reviewed changes

klovinad force-pushed the proposal/wheel-scroll-settings branch from 1813205 to 86fdb0d Compare June 14, 2026 09:09

greptile-apps Bot reviewed Jun 14, 2026

View reviewed changes

Comment thread crates/openlogi-agent-core/src/hook_runtime.rs Outdated

Comment thread crates/openlogi-core/src/binding.rs Outdated

Add wheel scroll settings

183eb59

klovinad force-pushed the proposal/wheel-scroll-settings branch from 86fdb0d to 183eb59 Compare June 14, 2026 12:57

klovinad and others added 3 commits June 14, 2026 16:23

Merge branch 'master' into proposal/wheel-scroll-settings

197fd96

Fix macOS transformed scroll units

853e71d

Fix scroll settings doc comments

e8b7819

AprilNEA reviewed Jun 15, 2026

View reviewed changes

AprilNEA requested changes Jun 15, 2026

View reviewed changes

KDTHEGREATEST added 2 commits June 15, 2026 23:14

Address PR 94 scroll transform review

28e63fe

Merge master into wheel scroll settings

43f5d86

klovinad mentioned this pull request Jun 15, 2026

Change default gesture swipes to desktop switching #270

Open

Merge branch 'master' into proposal/wheel-scroll-settings

88732b0

klovinad requested a review from AprilNEA June 16, 2026 20:09

Merge branch 'master' into proposal/wheel-scroll-settings

689183b

Merge master into proposal/wheel-scroll-settings

7612304

AprilNEA closed this Jun 22, 2026

Uh oh!

Conversation

klovinad commented Jun 2, 2026

Summary

Implementation notes

Verification

Uh oh!

pullfrog Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pullfrog Bot left a comment

Choose a reason for hiding this comment

Uh oh!

averypelle commented Jun 4, 2026

Uh oh!

phuocleoceo commented Jun 9, 2026

Uh oh!

shawnflanagan commented Jun 9, 2026

Uh oh!

averypelle commented Jun 10, 2026

Uh oh!

greptile-apps Bot commented Jun 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Sequence Diagram

Uh oh!

Uh oh!

Uh oh!

AprilNEA left a comment

Choose a reason for hiding this comment

1. It doesn't solve #126 (per-device inversion)

2. Modifier flags are dropped

3. Momentum / pixel precision are lost

4. Per-event cost on the hottest path

Suggested approach

Unrelated change

Uh oh!

zekunyan commented Jun 19, 2026

Uh oh!

AprilNEA commented Jun 22, 2026

Uh oh!

klovinad commented Jun 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

greptile-apps Bot commented Jun 14, 2026 •

edited

Loading